-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource azurerm_digital_twins_endpoint_eventgrid
#9489
New resource azurerm_digital_twins_endpoint_eventgrid
#9489
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yupwei68 This is looking really good, left a few comments. I think this is really close, thanks for the PR! 🚀
azurerm/internal/services/digitaltwins/digital_twins_endpoint_eventgrid_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/digitaltwins/digital_twins_endpoint_eventgrid_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/digitaltwins/digital_twins_endpoint_eventgrid_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/digitaltwins/digital_twins_endpoint_eventgrid_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/digitaltwins/digital_twins_endpoint_eventgrid_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/digitaltwins/parse/digital_twins_endpoint_test.go
Show resolved
Hide resolved
|
||
resource "azurerm_digital_twins_endpoint_eventgrid" "example" { | ||
name = "example-EG" | ||
digital_twins_instance_id = azurerm_digital_twins_instance.example.id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
digital_twins_instance_id = azurerm_digital_twins_instance.example.id | |
instance_id = azurerm_digital_twins_instance.example.id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
digital_twins_id?
|
||
* `name` - (Required) The name which should be used for this Digital Twins Eventgrid Endpoint. Changing this forces a new Digital Twins Eventgrid Endpoint to be created. | ||
|
||
* `digital_twins_instance_id` - (Required) The resource ID of the Digital Twins Instance. Changing this forces a new Digital Twins Eventgrid Endpoint to be created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* `digital_twins_instance_id` - (Required) The resource ID of the Digital Twins Instance. Changing this forces a new Digital Twins Eventgrid Endpoint to be created. | |
* `instance_id` - (Required) The resource ID of the Digital Twins Instance. Changing this forces a new Digital Twins Eventgrid Endpoint to be created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
digital_twins_id?
Thanks for your comments, @WodansSon . Corresponding changes have been pushed, except some my minor concerns. The parser and the parser test are all generated from Tom's tool, by https://github.com/terraform-providers/terraform-provider-azurerm/blob/master/azurerm/internal/services/digitaltwins/resourceids.go. I wonder if our changes will be overwrote if we make changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yupwei68 Thanks for pushing these changes. Since some of the changes are auto-generated the LGTM now! Thanks! 🚀
azurerm/internal/services/digitaltwins/parse/digital_twins_endpoint_test.go
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now! 🚀
This has been released in version 2.39.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.39.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Partial fix: #9211
=== RUN TestAccAzureRMDigitalTwinsEndpointEventGrid_basic
=== PAUSE TestAccAzureRMDigitalTwinsEndpointEventGrid_basic
=== CONT TestAccAzureRMDigitalTwinsEndpointEventGrid_basic
--- PASS: TestAccAzureRMDigitalTwinsEndpointEventGrid_basic (245.92s)
=== RUN TestAccAzureRMDigitalTwinsEndpointEventGrid_requiresImport
=== PAUSE TestAccAzureRMDigitalTwinsEndpointEventGrid_requiresImport
=== CONT TestAccAzureRMDigitalTwinsEndpointEventGrid_requiresImport
--- PASS: TestAccAzureRMDigitalTwinsEndpointEventGrid_requiresImport (235.73s)
=== RUN TestAccAzureRMDigitalTwinsEndpointEventGrid_updateEventGrid
=== PAUSE TestAccAzureRMDigitalTwinsEndpointEventGrid_updateEventGrid
=== CONT TestAccAzureRMDigitalTwinsEndpointEventGrid_updateEventGrid
--- PASS: TestAccAzureRMDigitalTwinsEndpointEventGrid_updateEventGrid (285.27s)
=== RUN TestAccAzureRMDigitalTwinsEndpointEventGrid_updateDeadLetter
=== PAUSE TestAccAzureRMDigitalTwinsEndpointEventGrid_updateDeadLetter
=== CONT TestAccAzureRMDigitalTwinsEndpointEventGrid_updateDeadLetter
--- PASS: TestAccAzureRMDigitalTwinsEndpointEventGrid_updateDeadLetter (301.37s)